search

fthx / dock-from-dash

GNU General Public License v3.0
96 stars 20 forks source link

Animate dock width changes outside of overview #76

Closed dgsasha closed 11 months ago

dgsasha commented 1 year ago

When the dock is set to 'always show', there is no animation when the width of the dock changes outside of the overview. I believe it's due to this line in dash.js, but I can't think of a good way to change this behavior. It's a fairly minor issue, but I find the lack of an animation slightly jarring, so let me know if you can think of a way to fix it.

dgsasha commented 1 year ago

I made some other improvements to how the dock works when it is set to 'always show' over here. I will probably open a pull request for those changes tomorrow. This issue wasn't one I could figure out how to solve though.

dgsasha commented 1 year ago

I got this working, although it's kind of an ugly solution. I copied the _redisplay method into the Dock class and changed the offending code that blocked animations outside of the overview there. Luckily this method hasn't changed since GNOME 40 so this solution shouldn't cause issues, but it isn't the prettiest solution.

fthx commented 1 year ago

I used this trick in dashbar extension...

fthx commented 11 months ago

There's no more a 'always show' option. For that, use DashBar extension that handles this in a better way.