fthx / dock-from-dash

GNU General Public License v3.0
97 stars 20 forks source link

Currently not working in Gnome 45 #91

Closed debianmain1 closed 1 year ago

debianmain1 commented 1 year ago

I updated to 45 a couple of days ago & updated the extension...It's currently not working in my system & I see this repeated in my logs.

``Oct 10 07:25:39 asus-z690 gnome-shell[2671]: JS ERROR: Invalid work id 3: Error: Invalid work id 3 queueDeferredWork@resource:///org/gnome/shell/ui/main.js:972:18 _queueRedisplay@resource:///org/gnome/shell/ui/dash.js:489:14 @resource:///org/gnome/shell/ui/init.js:21:20

I'm ready to do any checking you need. Note: This is just after a reboot/user login during gnome-session start.

fthx commented 1 year ago

I use GS 45 and it works on my system (Ubuntu 23.10). This error is "normal" and does not have any consequence, caused by GS not killing signals properly (Florian Muellner told me the native GS dash was not made intially to be used as a "new" object!).

Do you have any other extension installed? What's the exact version of GS?

debianmain1 commented 1 year ago

GS is 45.0-1 Arch Linux. I have several extensions installed....Applications Menu, Arch Linux Updates Indicator, Desktop Icons NG (DING), Dock from Dash, Lock Keys, Places Status Indicator, Screenshot Window Sizer, User Themes & GPaste. I'm thinking that maybe DING is causing a problem.....I installed Dash to Dock to check & it is working, so not sure what is going on......

I can shut off extensions -- leaving Dock on & log out/reboot -- then reenable one at a time to test. Will be doing that later this afternoon...have things to do this morning...

debianmain1 commented 1 year ago

Hmmmm.....real quickly I disabled all extensions except for Dock & rebooted....It still did not work on login....So it "looks" like its not an extension problem.....

I'll be back in about 4 hours to follow up on this.

debianmain1 commented 1 year ago

OK---I've restarted with all extensions disabled except for Dock......it is not starting. I uninstalled the extension & then reinstalled it....no start (used gnome extensions website).....this was again after disabling everything else...

I installed dash to dock & it works normally (even though I really don't want to use it)......

Not really sure where to go from here.......Your thoughts?

fthx commented 1 year ago

What are the errors in Logs related to "js" search?

debianmain1 commented 1 year ago

Sorry to not get back before now. I selected Dock & rebooted....logged in & no bottom dock...went through the logs & the only reference including js is:

gnome-shell[2058]: Execution of main.js threw exception: Module resource:///org/gnome/shell/ui/init.js threw an exception

Don't know if this helps or not.......

fthx commented 1 year ago

Sorry I have no idea why it does not work. I do not have atm any other user that told me that. Could you try to delete the extension's folder then reinstall it? I do not see any other way.

debianmain1 commented 1 year ago

OK...Yes...I'm not sure why also....worked great in 44...nothing in 45. I'll delete everything & give that a try.

debianmain1 commented 1 year ago

OK....I removed the extension via the extensions application, checked .local/gnome-shell for a folder, removed the various files from .local/gnome-shell (update-check-45, applications_state & some other cruft)---then rebooted & reinstalled Dock via the Gnome-Extensions website......still nothing. I'm going to do some more looking/thinking about this one....I'm stumped right now....

fthx commented 1 year ago

The big thing with this version (limited prefs will be back when I'll have some time) is the dock reveal code. So do you have a special monitor config?

fthx commented 1 year ago

Does Hot Edge (jdoda) extension work for you?

debianmain1 commented 1 year ago

I do not have a custom config...for my monitor & yes, the Hot Edge extension works for me.....

fthx commented 1 year ago

Last thing after that I resign: is this buggy in X11 and Wayland, both?

fthx commented 1 year ago

I think to a post of jdoda about a bug in GS45 that has been solved, but I did not experience such a bug that caused his mechanism not to work. Does Arch have some patchs in its GS 45?

debianmain1 commented 1 year ago

It is buggy in both Wayland & X11. As for patches....I'll need to check on that...not sure. Won't be able to get back to this for another 5 or so hrs....

debianmain1 commented 1 year ago

OK...this is from the Commit log for Gnome-Shell in Arch.

https://gitlab.archlinux.org/archlinux/packaging/packages/gnome-shell/-/tree/ded85beb8da18bad110cfb98408e7807477fbf2c

It looks like Arch pushed it without any patches.

KardinalReusen commented 1 year ago

I can confirm this bug. I have 3 arch installations and the dock is not working on any of them since Gnome 45.

fthx commented 1 year ago

I've just uploaded it again to verify, there's no difference with the (running in Ubuntu 23.10) version I have. If you have no errors ("JS" or "fthx") in Logs, I'm stuck here.

If you have some (limited) skills in JS, you can include : Main.notify("bump"); in some functions (names are clear) of the extension.js code, to know if the dock is triggered, then if the dock display function is executed.

KardinalReusen commented 1 year ago

the extension was updated a few minutes ago. No difference. Sorry I have no programming skills at all.

debianmain1 commented 1 year ago

I've just uploaded it again to verify, there's no difference with the (running in Ubuntu 23.10) version I have. If you have no errors ("JS" or "fthx") in Logs, I'm stuck here.

If you have some (limited) skills in JS, you can include : Main.notify("bump"); in some functions (names are clear) of the extension.js code, to know if the dock is triggered, then if the dock display function is executed.

I'll try this later today to see if I can get you some info......do you want this pasted to top of extension or last line?

fthx commented 1 year ago

Here please: image Just before or after the emit line.

fthx commented 1 year ago

This way I will know if the signal that is sent to the dock is activated (pressure on bottom of the screen, first part of the code, that emits this signal that the dock listens to).

fthx commented 1 year ago

Could you try this before hacking the code?

debianmain1 commented 1 year ago

Answer is r(0) = true

debianmain1 commented 1 year ago

I have "hacked" the extension...what is the output you want & how do you want it?

fthx commented 1 year ago

Do you have a notification when you hover the bottom of your screen?

debianmain1 commented 1 year ago

YES...I get the "bump" in notifications & the Dock appears...as soon as I mouse away...the Dock is gone.

fthx commented 1 year ago

so there never was any issue here... that's the way this dock works.

debianmain1 commented 1 year ago

Hmmm....is there a way to have the dock visible at all times unless a window overlapped like it was before 45?

fthx commented 1 year ago

It never had intelligent hide.