fthx / no-overview

GNU General Public License v3.0
71 stars 8 forks source link

Doesn't work with Ubuntu 21.10 Beta #9

Closed chdslv closed 2 years ago

chdslv commented 2 years ago

Doesn't work with Ubuntu 21.10 daily, the overview continue to be there. This extension is on anyway. By the way, it works on Fedora!

diaevd commented 2 years ago

Same

$ gnome-shell --version
GNOME Shell 40.5
$ echo $XDG_SESSION_TYPE 
wayland
fthx commented 2 years ago

Daniel Van Vugt from Ubuntu did hack GS allowing Dash to Dock to hide overview at start-up. One line in 40.5-1ubuntu1 changelog. So that's an Ubuntu bug. Note that I do use Impish.

If I remember correctly, DVV created a single gjs command to avoid overview at start-up. I'm open to a PR for Ubuntu.

chdslv commented 2 years ago

In Ubuntu Impish, this extension doesn't react at all, it is always with the overview. If there's a hide overview hack by DVV, by adding this extension broke that hack? Interestingly, with no hacks in Fedora 35, your extension works. I only added 41 to metadata.json.

fthx commented 2 years ago

Could you try the latest github code on Ubuntu+Fedora? I found again: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1943

fthx commented 2 years ago

Ok it works with Ubuntu 21.10 without errors. Just have to try Fedora.

fthx commented 2 years ago

Could @fujiwarat check this too? Thanks!

fthx commented 2 years ago

Please check the logs, of course!

chdslv commented 2 years ago

Yes, works with Impish and Fedora 35. Thanks!

fthx commented 2 years ago

I tested this in a Fedora 35 VM, it works too.

So I close this now. Feel free to reopen if needed.

I'm interested in knowing if just the "startInOverview" part is sufficent in Fedora 35. If you can test this?

chdslv commented 2 years ago

I am not good at coding, so all I can say is that, the old extension, and the new one works with Fedora 35. By the way, thank you very much for all your simple extensions. :)

fthx commented 2 years ago

Could you check the very latest github version? I received an error report (without any detail) for Fedora 34 for the current version.

fthx commented 2 years ago

That's already online in GS ext website!

chdslv commented 2 years ago

I have Fedora 35, not 34. The versions 7, 8, 9 and 10 of your extension worked correctly with Fedora 35. In the version 7, I added 41 to metadata.json. In Impish, both version 9 and 10 works.

ylxdzsw commented 2 years ago

Not very related, but I just glanced at the code and find line 34 weird: we just set that variable to false in line 26, so I think it is always a no-op. Has anyone tested disabling the extension in Ubuntu?

fthx commented 2 years ago

I don't understand the point here. I just reenable the overview at start-up when disabling the extension. Probably it's not useful as restarting the session does clear all that but anyway I find that's a good practice to let Gnome shell in a native state when disabling, assuming nobody does use this extension and Ubuntu dock at the same time.

fthx commented 2 years ago

If you ask about the "if" that's just to check if the variable does exist to avoid any error on systems without it (some non-Ubuntu GS 40, maybe outdated ones).

ylxdzsw commented 2 years ago

@fthx Yes, but even if the variable exist, its value is "false", so the branch is still not entered.

fthx commented 2 years ago

Yes, maybe I should add || !Main.layoutManager.startInOverview ? Or do nothing.

What do you think?

fthx commented 2 years ago

Additionally FYI, I don't check first the existence of Main.layoutManager.startInOverview before entering "old" hiding method. Because as I experienced, the variable can exist BUT not be used by the system...

ylxdzsw commented 2 years ago

I'm no expert and don't use Ubuntu so can't say for sure. I think it would be fine to just set it even if it does not exist. Storing an additional (potentially unused) bool does not hurt anything, right?

fthx commented 2 years ago

https://github.com/fthx/no-overview/commit/857c68537c8b01b295d9df8599f27e8b7eaa2721

Thanks for pointing that.