search

ftlabs / fastclick

Polyfill to remove click delays on browsers with touch UIs
MIT License
18.66k stars 3.22k forks source link

Chrome on Andriod #125

Closed inscore closed 10 years ago

inscore commented 11 years ago

Doesn't seem to have any effect on the latest version of Chrome for Andriod (4.2.2). Haven't tested in older versions of Chrome.

Tested and working on same device in Firefox, Opera, and "Browser" Also works fine on iOS safari as well as Chrome on iOS.

k2xl commented 11 years ago

Same here :-. Still getting 300 ms delay

multiplegeorges commented 11 years ago

On the Basic Use demo, I get a consistent 17-20ms delay on the B button. Testing the same thing on iOS 5/iPhone4S gets me a 0ms.

Based on what the docs say, Chrome on Android is exempt from fastclick. It probably should not be exempt.

jpcamara commented 11 years ago

I am having the 300ms delay as well. The only way for me to get rid of it (on my Nexus 7) is to remove user-scalable=no so that FastClick doesn't ignore android.

Basic use doesn't have the 300ms delay on it, but that's because it doesn't have user-scalable=no specified. Not sure where the info on Chrome on Android not needing it with user-scalable, but it definitely doesn't appear consistent across devices (in reference to this https://github.com/ftlabs/fastclick#when-it-isnt-needed)

eremzeit commented 11 years ago

Chrome on Android with user-scalable=no in the viewport meta tag as it is not needed

Maybe the docs changed since you posted this, but the user-scalable=no part is important.

@multiplegeorges

matthew-andrews commented 10 years ago

4 months ago our Chrome for Android logic was enhanced by https://github.com/ftlabs/fastclick/commit/5ff301160d38eb834bd1d0e2240495d273d68183. This issue predates that commit and hasn't had any activity since then so I think it's safe to close this issue.