ftlabs / fastclick

Polyfill to remove click delays on browsers with touch UIs
MIT License
18.66k stars 3.22k forks source link

bower install getting 0.6.9, npm install getting 0.6.11 #202

Closed kinergy closed 10 years ago

kinergy commented 10 years ago

Hi, something is screwy with the bower.json file and despite cleaning my bower cache, I still get 0.6.9, even though it declares version 0.6.10.

Worse, the latest is 0.6.11, if you refer to fastclick.js and package.json

Please fix.

matthew-andrews commented 10 years ago

Apologies for the short delay. This should be fixed by this and retagging.

Before:

[matthew.andrews@wilson-mba ~]$ bower install fastclick
bower not-cached    git://github.com/ftlabs/fastclick.git#*
bower resolve       git://github.com/ftlabs/fastclick.git#*
bower download      https://github.com/ftlabs/fastclick/archive/v0.6.10.tar.gz
bower extract       fastclick#* archive.tar.gz
bower resolved      git://github.com/ftlabs/fastclick.git#0.6.10
bower install       fastclick#0.6.10

fastclick#0.6.10 bower_components/fastclick

After:

$ bower install fastclick
bower not-cached    git://github.com/ftlabs/fastclick.git#*
bower resolve       git://github.com/ftlabs/fastclick.git#*
bower download      https://github.com/ftlabs/fastclick/archive/v0.6.11.tar.gz
bower extract       fastclick#* archive.tar.gz
bower resolved      git://github.com/ftlabs/fastclick.git#0.6.11
bower install       fastclick#0.6.11

fastclick#0.6.11 bower_components/fastclick

I then md5'd lib/fastclick.js in both the bower components folder and in a fresh check out of the repository to confirm that they were the same:

$ md5 bower_components/fastclick/lib/fastclick.js
MD5 (bower_components/fastclick/lib/fastclick.js) = e8c9ffb8cc42b4b473c4f620ddab65b1
$ md5 fastclick/lib/fastclick.js
MD5 (fastclick/lib/fastclick.js) = e8c9ffb8cc42b4b473c4f620ddab65b1

So I think this should work for you now. Would you be able to confirm? Thanks.

matthew-andrews commented 10 years ago

I believe this to be fixed so I will close this issue. Please re-open / raise a new issue if you still encounter problems :).