search

ftlabs / fastclick

Polyfill to remove click delays on browsers with touch UIs
MIT License
18.66k stars 3.23k forks source link

Duplicate click on span #247

Open matthewpomar opened 10 years ago

matthewpomar commented 10 years ago

Hi,

We are using the latest version of FastClick 1.0.1 and getting a duplicate click on a span element. I tried adding the class "needsclick" but it had no affect. If I don't use FastClick, the problem does not occur.

Is there a way to initialize FastClick, excluding certain elements since the "needsclick" method doesn't appear to work (at least for my situation)?

Thank you!

matthew-andrews commented 10 years ago

I've put together 'selective-fastclick' to help in this case - https://github.com/matthew-andrews/selective-fastclick.

But you shouldn't get a double click on span elements - do you have a reduced test case / list of affect devices we can take a look at?

matthewpomar commented 10 years ago

Thanks. I'll check this out. No, I don't have a test case yet. I imaging the problem is caused by the complexities in our solution/setup, so stripping it down to a simple existing will likely result in FastClick working just as intended.

kaansoral commented 10 years ago

I've switched from 0.6.11 to 1.0.1 and experienced a similar issue with an input on Android 2.3/Phonegap, again a complex setup.

I had the impression that FastClick was always heavily tested and foolproof, this doesn't seem to be the case, better not update

BC17 commented 10 years ago

seems similar to this issue: https://github.com/ftlabs/fastclick/issues/244