Omit listeners on BlackBerry 10.3+

[oros]

It's been reported that BlackBerry 10 does not have the inherent 300ms delay, thus shouldn't require the Fastclick.js library. That being said, many developers will include Fastclick.js as a part of targeting multiple OS platforms.

There have been issues which arose around elements and similar input elements not receiving touch events properly when Fastclick.js is included. One option would be to investigate these in-depth, the other would be to prevent Fastclick.js from attaching to BlackBerry 10 as the delay should not be present to begin with.

Would be great to hear any additional insight or views on this.

matthew-andrews commented 10 years ago

@georgecrawford as our resident BB10 expert would you mind commenting on this? Assuming @oros's experience is consistent with our's we should just be able to add a check in the notNeeded method.

Jaybuz commented 10 years ago

I don't see any checks for Firefox either. See: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff2a1d3d39f2

matthew-andrews commented 10 years ago

Hi @oros we just checked the BB10 devices we have in the office (v10.2) by comparing the two times when clicking the two buttons here:- http://ftlabs.github.io/fastclick/examples/layer.html. As far as we can tell BB10 still does require FastClick.

Are we doing something wrong?

matthew-andrews commented 10 years ago

@Jaybuz we'd be more than happy to consider a pull request that removes listeners on Firefox.

oros commented 10 years ago

@matthew-andrews My information's based on what was reported by our internal teams here but I think it may be related to the OS version.

In testing on 10.3 (using that test page), I saw the following:

If I'm not mistaken, that indicates no difference?

If your testing was on 10.2.0, that may be the cause but it may still be required in 10.2.1 as well; will need to test that still. 10.2.1 and 10.3 (beta) builds are available here: https://developer.blackberry.com/blackberry10devalphas/update/

I'm not sure how we'd want to differ based on specific OS versions without resorting to user-agent.

matthew-andrews commented 10 years ago

Oh wow that's fantastic news. So looks like Blackberry have removed the tap delay on 10.3?

UA sniffing is how we've tended to deal with this problem before (with some exceptions).

I've amended the Issue status to be "Omit listeners on BlackBerry 10.3+.

Would you like to prepare a pull request or leave this to us? (It might be quite a while before we get time to look into this)

oros commented 10 years ago

Sure thing, I can put it together. It may be a few days as I want to double-check and be certain on the OS versions but I'll post something back here soon.

matthew-andrews commented 10 years ago

Ah. We just figured out you work for Blackberry. It all makes sense now ;-)

oros commented 10 years ago

Yes yes :-) Should have mentioned that in hindsight.

matthew-andrews commented 10 years ago

We are running 10.2.1.1925 - and it seems to still have the delay. So perhaps it's a 10.3+ only?

oros commented 10 years ago

I believe this here should capture it: https://github.com/ftlabs/fastclick/pull/255

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[matthew-andrews]

@georgecrawford as our resident BB10 expert would you mind commenting on this? Assuming @oros's experience is consistent with our's we should just be able to add a check in the notNeeded method.

[Jaybuz]

I don't see any checks for Firefox either. See: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff2a1d3d39f2

[matthew-andrews]

Hi @oros we just checked the BB10 devices we have in the office (v10.2) by comparing the two times when clicking the two buttons here:- http://ftlabs.github.io/fastclick/examples/layer.html. As far as we can tell BB10 still does require FastClick.

Are we doing something wrong?

[matthew-andrews]

@Jaybuz we'd be more than happy to consider a pull request that removes listeners on Firefox.

[oros]

@matthew-andrews My information's based on what was reported by our internal teams here but I think it may be related to the OS version.

In testing on 10.3 (using that test page), I saw the following:

If I'm not mistaken, that indicates no difference?

If your testing was on 10.2.0, that may be the cause but it may still be required in 10.2.1 as well; will need to test that still. 10.2.1 and 10.3 (beta) builds are available here: https://developer.blackberry.com/blackberry10devalphas/update/

I'm not sure how we'd want to differ based on specific OS versions without resorting to user-agent.

[matthew-andrews]

Oh wow that's fantastic news. So looks like Blackberry have removed the tap delay on 10.3?

UA sniffing is how we've tended to deal with this problem before (with some exceptions).

I've amended the Issue status to be "Omit listeners on BlackBerry 10.3+.

Would you like to prepare a pull request or leave this to us? (It might be quite a while before we get time to look into this)

[oros]

Sure thing, I can put it together. It may be a few days as I want to double-check and be certain on the OS versions but I'll post something back here soon.

[matthew-andrews]

Ah. We just figured out you work for Blackberry. It all makes sense now ;-)

[oros]

Yes yes :-) Should have mentioned that in hindsight.

[matthew-andrews]

We are running 10.2.1.1925 - and it seems to still have the delay. So perhaps it's a 10.3+ only?

[oros]

I believe this here should capture it: https://github.com/ftlabs/fastclick/pull/255