search

ftlabs / fastclick

Polyfill to remove click delays on browsers with touch UIs
MIT License
18.65k stars 3.22k forks source link

Fastclick breaks <select> on Chrome 53+ #497

Open RByers opened 8 years ago

RByers commented 8 years ago

We (chromium) fixed our spec-compliance bug that allowed JS-generated mousedown events to open <select> boxes in Chrome 53. We just realized now (as 53 is going out to Android stable) that this breaks fastlick. Of course there's no good reason to rely on FastClick on Chrome anymore, but lots of pages still do.

We're still trying to figure out if we should undo our chromium change. But separately, perhaps FastClick should stop relying on this non-standard behavior? Maybe instead just don't intercept touches that go to <select> boxes?

Even better, just do #498.

brendanfalkowski commented 7 years ago

Got bitten by this today. The Browserstack fleet of devices must've just received updates past Chrome 53 because I'm suddenly seeing this issue go all the way back to Android 4.4 now.

In newer projects I stopped using Fastclick because of wider support of better touch handling, but looks like I need to start pulling it out of older projects. Heading that direction now.