search

ftlabs / fastclick

Polyfill to remove click delays on browsers with touch UIs
MIT License
18.66k stars 3.23k forks source link

Fastclick doesn't work for iOS 4.3.3 #52

Closed laurentbackelite closed 11 years ago

laurentbackelite commented 11 years ago

Hi

I had to disable fastclick because visitors using iOS 4.3.3 were unable to reliably click on links, I've had this confirmed using an iPhone : sometimes clicks will work, sometimes they'll not.

I've seen FastClick.prototype.deviceIsIOS4, has anyone really managed to get clicks 100% working under iOS4 ?

laurent

mattcg commented 11 years ago

Thank you for reporting. iOS 4 has become a little bit more difficult to test lately as Apple have dropped support in the iOS Simulator shipped with Xcode for Mountain Lion.

However, we still aim to achieve support for iOS and now have an iPad running 4.3.1 sitting on my desk :)

What does your test case look like - is it just a normally scrolling page with anchor tags? Have users reported the problem on iPhone only or can it be reproduced on an iPad?

laurentbackelite commented 11 years ago

Hi

It was a normal page, the only reports were iPhones 4.3.3, I guess nobody uses iOS4 on iPad anymore.

larent

mattcg commented 11 years ago

OK, thanks for clarifying.

mattcg commented 11 years ago

I can reproduce this using examples/layer.html. The condition at lib/fastclick.js:359 seems to be true.

mattcg commented 11 years ago

Fixed, although at the cost of a regression of issue #23 in Safari on iOS 4.

laurentperez commented 11 years ago

Thanks !

ismusidhu commented 10 years ago

Commenting these lines seems to fix an issue we had with our iPhone5 customers where they are not able to tap/click on buttons/textboxes but they can submit using keypad Go button. https://github.com/ftlabs/fastclick/blob/master/lib/fastclick.js#L388-L391

I'm sure it is going to have some adverse behaviour also but don't know what it would be.

Thought of sharing it here in case it is related.

Also to note that it has surprisingly came up today when many of our customers reported it when the same code is in production from long time. Might be that Apple/webkit has released an update.