search

ftlabs / fastclick

Polyfill to remove click delays on browsers with touch UIs
MIT License
18.66k stars 3.22k forks source link

Samsung Internet does not get polyfilled #522

Open patrickhlauke opened 7 years ago

patrickhlauke commented 7 years ago

Samsung Internet (Beta, based on Blink 537.36, with user agent advertising it as a Chrome/51.0.2704.106...among other things) still has the 300ms delay (tested on a page with width=device-width https://patrickhlauke.github.io/touch/fastclick/fastclick.html where Samsung Internet currently doesn't magically optimize the 300ms delay away like real Chrome etc do)

apaleslimghost commented 7 years ago

This is probably falling foul of https://github.com/ftlabs/fastclick/blob/master/lib/fastclick.js#L754-L761. This isn't really something that can be feature-detected, so we rely on UA parsing, which doesn't work in this case.

I might have time to look at this this week.

patrickhlauke commented 7 years ago

super, thank you (in parallel, i think Samsung folks are looking at this from their end as well https://twitter.com/jungkees/status/841072959754199041)