search

ftlabs / fastclick

Polyfill to remove click delays on browsers with touch UIs
MIT License
18.66k stars 3.23k forks source link

Tag each release (required by Bower) #65

Closed deanbrowne closed 11 years ago

deanbrowne commented 11 years ago

While trying to move my dependencies to Twitter Bower I noticed Bower requires tags for each version. Even though component.json correctly specifies 0.5.4 Bower will only pull 0.3.0.

> bower install fastclick git://github.com/ftlabs/fastclick.git
GET https://bower.herokuapp.com/packages/fastclick
bower cloning git://github.com/ftlabs/fastclick.git
bower caching git://github.com/ftlabs/fastclick.git
bower fetching fastclick
bower checking out fastclick#v0.3.0
bower copying ~/.bower/fastclick/f5a7850ce3cca7d71f9b1d777164ee29
bower cloning git://github.com/ftlabs/fastclick.git
bower cached git://github.com/ftlabs/fastclick.git
bower fetching fastclick
bower checking out fastclick#v0.3.0
bower copying ~/.bower/fastclick/f5a7850ce3cca7d71f9b1d777164ee29
bower installing fastclick#0.1.0

Perhaps related, Bower seems to have some trouble with its bower update command because there is no 0.1.0 tag.

> bower update
bower cloning git://github.com/ftlabs/fastclick.git
bower cached git://github.com/ftlabs/fastclick.git
bower fetching fastclick
Can not find tag satisfying: fastclick#~0.1.0

I'm guessing that just creating a tag for the latest 0.5.4 release will fix everything since the latest tag (0.3.0) doesn't have a component.json file.

mattcg commented 11 years ago

Thank you for reporting. I've created a tag for 0.5.4 and will bear this issue in mind when bumping the version from now on.

deanbrowne commented 11 years ago

Thanks! I was able to successfully reference it from component.json by adding a dependency.

"dependencies": {
  ...
  "fastclick": "0.5.x"
}