search

ftlabs / fruitmachine-media

FruitMachine helper that allows different setup and teardown callbacks to be called based on media queries
MIT License
6 stars 3 forks source link

Removed microoptimization #14

Closed kornelski closed 9 years ago

kornelski commented 9 years ago

Causes problems when required() in node

matthew-andrews commented 9 years ago

I think the test might be missing a setImmediate plugin?

kornelski commented 9 years ago

Odd: window.constructor.prototype.setImmediate exists, but window.setImmediate doesn't. My guess that the polyfill is smarter than PhantomJS?

matthew-andrews commented 9 years ago

hack hack hack

kornelski commented 9 years ago

Yay!

kornelski commented 9 years ago

@orangemug yes, there's at minimum 4ms timeout

I'd like to point out that the controversial line is not used in any browser. It's only to work around bizarre behaviour that appears to be a phantomjs bug.

AdaRoseCannon commented 9 years ago

It should still work fine regardless.