search

ftlabs / fruitmachine

View rendering engine
MIT License
247 stars 18 forks source link

The `parent` attribute is not being cleared when a view is `.remove()`ed #20

Closed wilsonpage closed 11 years ago

matthew-andrews commented 11 years ago

Oh really? That's interesting. Was it not my hare logic then after all?

wilsonpage commented 11 years ago

You should have always been calling .destroy() not .remove(). This was just a small observation I made :). remove() simply removes a view from it's current nested context. It's suitable for views that haven't been rendered yet, or views that you wish to move to a new location.

On Fri, May 3, 2013 at 11:41 AM, Matt Andrews notifications@github.comwrote:

Oh really? That's interesting. Was it not my hare logic then after all?

— Reply to this email directly or view it on GitHubhttps://github.com/wilsonpage/fruitmachine/issues/20#issuecomment-17388245 .

matthew-andrews commented 11 years ago

Ah ok. Understood.

wilsonpage commented 11 years ago

Fixed at ba9662a3