search

ftlabs / fruitmachine

View rendering engine
MIT License
247 stars 18 forks source link

Would it make sense to have an #undefine method? #36

Closed matthew-andrews closed 11 years ago

matthew-andrews commented 11 years ago

Although lightly used it is a bit strange that in unit tests we're currently just manipulating fruitmachine's internal modules object:

https://github.com/ftlabs/fruitmachine/blob/master/test/tests/define.js (see teardown)

wilsonpage commented 11 years ago

As fruitmachine.modules is 'public' I think it is safe to allow users to call delete fruitmachine.modules.apple in the unlikely event they wish to unregister a module. This means we can keep API as small as possible. If there is demand for this feature, then yes we should implement.

Closing this for now.

matthew-andrews commented 11 years ago

That seems reasonable. Thanks!