ftlabs / fruitmachine

View rendering engine

MIT License

247 stars 18 forks source link

Remove built javascript from repo to avoid it getting out of date; link to Browserify CDN for built version #57

Closed matthew-andrews closed 9 years ago

matthew-andrews commented 10 years ago

As discussed here.

Also a bit of spring cleaning:

Updating dependencies
Jshinting tests (not completely fixed issues here - but mostly)
Updating tests to use busterjs's latest version.

DONT MERGE YET

I've broken bower. To be continued...

wilsonpage commented 10 years ago

I think the test suite depends on the built version. Also I think we require the standalone option for the Browserify build.

matthew-andrews commented 10 years ago

For the test suite I should have solved that with: https://github.com/ftlabs/fruitmachine/commit/c464313c82a70c6517e3cc37cc426289a1835298

Weirdly it was coveralls that caused the failed build for this: https://travis-ci.org/ftlabs/fruitmachine/builds/16870463

I'm not sure what you mean by standalone option?

coveralls commented 10 years ago

Coverage remained the same when pulling df6058770aefd4266d81aa9574227d144ff6586a on nocompiled into 446522b6e9103ad8405f195eee2a3d293eadac01 on master.

coveralls commented 10 years ago

Coverage remained the same when pulling df6058770aefd4266d81aa9574227d144ff6586a on nocompiled into 446522b6e9103ad8405f195eee2a3d293eadac01 on master.

matthew-andrews commented 10 years ago

Jamie @orangemug would you mind having a look at this?

wilsonpage commented 10 years ago

Do we still want to do this following the Bower debacle?

matthew-andrews commented 10 years ago

Yes but not yet. I've got it to build with some forks of the dependencies with minimal changes to them (just adding bower.jsons) with debowerify.

matthew-andrews commented 10 years ago

Pull requests here:

https://github.com/wilsonpage/extend/pull/2 https://github.com/wilsonpage/utils/pull/1 https://github.com/wilsonpage/mixin/pull/1