search

ftlabs / fruitmachine

View rendering engine
MIT License
247 stars 18 forks source link

Adding SVG support #86

Closed orangemug closed 9 years ago

orangemug commented 10 years ago

I know this still requires some tidying (tests). But I just thought I'd put it up here to get some feedback. Basically adding {isSVG: true} to a module will make it behave correctly as an SVG element.

@rowanbeentje, @matthew-andrews, @georgecrawford if I clean up this pull request are you happy to merge?

orangemug commented 10 years ago

Any interest in going forward with this pull request?

rowanbeentje commented 9 years ago

I think this would be a Good Thing, even if I don't have an immediate use case for it.

It feels like there's a lot of SVG-specific code in .render which might be worth abstracting out to elsewhere...?

orangemug commented 9 years ago

Agreed, I'll pull out the SVG bits into a util lib

orangemug commented 9 years ago

Oh also this feature is currently used in production.

orangemug commented 9 years ago

I have no time to work on this and don't use the library anymore, closing pull request.