ftlabs / ftcolumnflow

A polyfill that fixes the inadequacies of CSS column layouts
MIT License
633 stars 51 forks source link

Vertical Space in demos #47

Open fedorinoGore opened 9 years ago

fedorinoGore commented 9 years ago

It looks like all demos are showing that the library has some kind of troubles with vertical space adjustment. All of them are scrollable far beyond any visible content, especially in vertical direction. Is it possible to do something with that?

r007 commented 9 years ago

It's because visibility of #flowedContent and #fixedContent is set to hidden, technically, they're not completely hidden. They still take space, that's why your page is scrollable far beyond. If you want to fix this issue, simply replace in css file visibility: hidden; on display: none; like that:

#flowedContent, #fixedContent {
    display: none;
}

P.S. I'm not a FTLabs developer, just wanted to help.

georgecrawford commented 9 years ago

Thanks Sergey, I'd never noticed this.

Would you care to open a PR to fix this?

George


George Crawford Senior Developer, Financial Times

+44 (0)752 567 9717 Number One Southwark Bridge, London SE1 9HL

On 11 Oct 2015, at 18:14, Sergey Monin notifications@github.com wrote:

It's because visibility of #flowedContent and #fixedContent is set to hidden, technically, they're not completely hidden. They still take space, that's why your page is scrollable far beyond. If you want to fix this issue, simply replace in css file visibility: hidden; on display: none; like that:

flowedContent, #fixedContent {

display: none;

} P.S. I'm not a FTLabs developer, just wanted to help.

— Reply to this email directly or view it on GitHub.


This email was sent by a company owned by Pearson plc, registered office at 80 Strand, London WC2R 0RL. Registered in England and Wales with company number 53723.

r007 commented 9 years ago

Okay, I'll open a bit later.

r007 commented 9 years ago

50 #49 Fixed here.