Break Gracefully - Githubissues

ftlabs / perf-widget

22 stars 2 forks source link

Break Gracefully #80

Closed AdaRoseCannon closed 8 years ago

AdaRoseCannon commented 8 years ago

Use Bertha for Blacklisting sites. https://docs.google.com/spreadsheets/d/1_f-cR8VbcujCsjxTLyKVRcG9yp_qUbT0-FrdmwBp0OM/edit#gid=0
Response will timeout after 4 minutes.
In Bertha string matches can use wildcards
In Bertha regexp matches can also be used.

AdaRoseCannon commented 8 years ago

Fixes #75

AdaRoseCannon commented 8 years ago

^^^^ Try again button

Although I think it shouldn't be present on this particular error message since the blacklist won't change regularly. (Blacklist checks for updates each hour)

Also I need to fix the refresh button at the top intersecting with the text.

JakeChampion commented 8 years ago

I'm not in favour of this PR -- I've left a comment on the issue with my reasoning -- https://github.com/ftlabs/perf-widget/issues/75#issuecomment-183289556

AdaRoseCannon commented 8 years ago

Going for a different implementation.