search

ftlabs / perf-widget

22 stars 2 forks source link

Don't show the insights on personalised pages #87

Closed seanmtracey closed 8 years ago

seanmtracey commented 8 years ago

Content that's been manipulated according the users preferences may not return results that actually align with what's being displayed. We should not surface these insights, but instead alert the user that the page is customised to their usage, and that we cannot provide reliable insight.

JakeChampion commented 8 years ago

How do we know if a page is personalised?

AdaRoseCannon commented 8 years ago

This may be utter craziness:

Super strict: check a hash of document.body.textContent to see if the text is different OR Kinda strict: produce a map of the DOM nodes/ids/classes/heirarchies and compare that

seanmtracey commented 8 years ago

I don't think that would be wise. Don't we run the risk of supressing insights on any page that has AJAX functionality?

JakeChampion commented 8 years ago

As well as pages which have adverts or simply pages which change their content (such as a news index page).