ftomassetti / LangSandbox

Project to illustrate how to build a programming language
Apache License 2.0
694 stars 90 forks source link

Enforce Code Consistency #8

Closed tajmone closed 4 years ago

tajmone commented 4 years ago

Enforce Code Consistency

In order to improve cross-platform collaboration and to enforce consistent code-style in the project:

tajmone commented 4 years ago

Se sei interessato allo storico di questo PR, puoi trovare copia della branch di lavoro (con tutti i vari commit, passo-passo) nel branch di backup code-styles.dev (prima dello squash):

ftomassetti commented 4 years ago

Thank you for the PR, I appreciate it. I will need some time to review it. I am also considering updating these tutorials. Some things may be a bit advanced for the code used in a tutorial. Also, I was planning to start using GitHub actions instead of Travis

tajmone commented 4 years ago

Thank you for the PR, I appreciate it.

You're welcome.

I will need some time to review it.

No hurry. But at least in the meantime I can edit locally the files with my editor picking-up the settings consistently.

Also, I was planning to start using GitHub actions instead of Travis

The only potential downside of GitHub Actions is the monthly limit (which could be reached quite easily as the number of repositories grows). This is why I try to use Travis CI or Circle CI for anything that doesn't require some GitHub-specific functionality.

Also, the upside of using Travis is that you can test build cross-platforms, including Win OS (only x64 VMs are supported, but the Win Server VM can also run legacy 32-bit apps).

tajmone commented 4 years ago

I've rebased on master, so all conflicts should be solved now.

tajmone commented 4 years ago

In any case, using Travis CI doesn't prevent using GitHub Actions too (or other CI services like Circle CI). So we could even have multiple badges for the various build-checks.

tajmone commented 4 years ago

GitHub Action Error

I noticed that the GitHub Action is currently failing on Build with Gradle.

We might want to wait that the problem is fixed upstream before merging this PR — just in case it might need some conflicts resolution for rebasing, or editing settings after.

ftomassetti commented 4 years ago

Thank you Tristano, this is appreciated! I will investigate the issue with the github action