Implemented item 7 of the book (linter mode).

ftomassetti / effectivejava

Run queries on your Java code to check if it meets the criteria suggested by the book Effective Java. And some others.

Apache License 2.0

507 stars 45 forks source link

Implemented item 7 of the book (linter mode). #38

Closed davidor closed 9 years ago

davidor commented 9 years ago

Now the program alerts the user when it finds classes that call finalize(). This corresponds to item 7 in the effective Java book. For now, it only works in the linter mode.

davidor commented 9 years ago

I've added sample classes and tests for the 2 cases that you mentioned. The code passes the tests. However, I still need to modify it to use the classes of the javaparser that you mentioned before.

ftomassetti commented 9 years ago

Thank you, I think the current solution would cover the 99% of real usages. A couple of other cases that would be not covered:

"finalize()" in a string would be recognized
finalize( ) or finalize () would be not recognized because of the spaces

davidor commented 9 years ago

I am using the java parser now. Please check that everything is OK.

ftomassetti commented 9 years ago

Looks very good, thanks a lot!