Interest in a PR for Windows support?

ftpsolutions / python-third-party-license-file-generator

A tool that walks your Python project's requirements and gathers the third party licenses for you

MIT License

13 stars 5 forks source link

Interest in a PR for Windows support? #1

Closed fredvisser closed 5 years ago

fredvisser commented 5 years ago

The current version has a handful of minor issues (e.g. subprocess.Popen(…) has platform specific arguments, some path concatenation using '/', and string parsing that fails with invalid characters) that prevent the tool from running correctly on Windows.

Would you be interested in an PR that fixes these?

initialed85 commented 5 years ago

I'm not actually a part of the owning organisation any more, but I imagine the guys will appreciate it!

You'll need their assistance to push the new version to PyPI but that's reasonably trivial for them I believe.

fredvisser commented 5 years ago

Thanks for the response! I've created a PR with fixes for the issues I've seen on Windows.

It's a super helpful tool, and I really appreciate the work that went into creating it. Thanks!

lowaa commented 5 years ago

Thanks. Version 2019.10 has been released to pypi :)