fix: projects now have the right attributes

ftrackhq / ftrack-ts-schema-generator

Gets the schema from an ftrack instance and generates typescript interfaces for all the entity types in the instance.

Apache License 2.0

2 stars 1 forks source link

fix: projects now have the right attributes #46

Closed ffMathy closed 1 month ago

ffMathy commented 1 month ago

[X] I have added automatic tests where applicable
[X] The PR title is suitable as a release note
[X] The PR contains a description of what has been changed
[X] The description contains manual test instructions

Changes

Before, project attributes were not typed correctly. This fixes that.

Test

N/A

gismya commented 1 month ago

What is the new condition checking exactly?

ffMathy commented 1 month ago

Not sure if it's correct. But before, when I created #42, that didn't work for projects.

That's because for projects, the entity type is called "show", which doesn't translate correctly. The existing code checks for a 1-to-1 match between the entity name in the schema and the given attribute's type name.

So the generated types for the projects are wrong. For instance, Project should also have the attribute fps on it, but it does not.

ffMathy commented 1 month ago

Thanks for merging. Can we get it released too? :heart:

ffMathy commented 3 weeks ago

@gismya?

gismya commented 3 weeks ago

Sorry, missed the first message. New version has been deployed.