ftranghese / EC601-Fall2017-Seamless-Track-Detection

16 stars 8 forks source link

Code Review Yize Liu #15

Closed lyztxyd1995 closed 6 years ago

lyztxyd1995 commented 6 years ago

Readme.md

The readme file briefly introduce the goal of this project and show the current achievement, but I think it would be better to illustrate the organization of the whole project more clearly. For example, it would be better if you write the functions of each part of codes. In this way, it will be easier for us to give a code review.

line_fit.py

I think there may exits some redundant codes in this file. The function viz1() and viz2() show a great similarity so that I think they could be somehow combined together to reduce the length of the code.

fully_conv_NN.py

The exits many replicate codes and functions in this file, such as model.add(), which takes about 50 lines to repeated call the same function. I think it might be better to use some tricks to simply the codes, maybe use a for loop of enum to achieve the same goal with fewer lines of codes.

Summary

The project is very impressive and the demo is very complete, which contains the video, images and link. I really look forward to your final sprint. I think it must be an attractive and amazing application when it is finished.