search

ftrrtf / FtrrtfRollbarBundle

[Deprecated] Symfony2 Bundle for rollbar.com
MIT License
13 stars 16 forks source link

Update scrutinizer config #12

Closed ftrrtf closed 9 years ago

ftrrtf commented 9 years ago

@mplachta please have a look on it

mplachta commented 9 years ago

Looks good, generally I think that following PSR-2 is crucial here.

I think that scrutinizer is good, but maybe we should add phpmd and phpcs as dependencies so the developer is able to perform quality check on his own?

Take a look at https://github.com/Schibsted-Tech-Polska/php-sndapi (especially composer.json and gruntfile.js).

Also remember to squash commits before you merge, it's easier to find all changes in the future.

ftrrtf commented 9 years ago

@mplachta I would not like to add a new dependencies (node/npm/grunt) for this, especially it's not PHP stack.

mplachta commented 9 years ago

Sure, that just makes it easier to run all tools. What about adding phpmd, phpcs, phpcpd and phploc? This way anybody contributing could check the code before sending pull-request.

ftrrtf commented 9 years ago

@mplachta Yes, I think it makes sense to add it. But certainly not in this brunch.

mplachta commented 9 years ago

Cool, go ahead then :) :+1: