search

ftschindler / paper-2022-certified-adaptive-RB-ML-ROM-hierarchy

A new certified hierarchical and adaptive RB-ML-ROM surrogate model for parametrized PDEs (2022) by Haasdonk, Kleikamp, Ohlberger, Schindler, Wenzel
Other
2 stars 0 forks source link

revisit shipping pyMOR and VKOGA #1

Open ftschindler opened 1 year ago

ftschindler commented 1 year ago

I'm not certain if shipping pyMOR and VKOGA within the repo is a good solution here. We could also pull them in (via git submodules or tar releases), and have our customisations applied as a simple patch. On the other hand, shipping the exact versions means this repo is somewhat self-contained (apart from the pip dependencies). Any thoughts, @sdrave @renefritze @henklei?

HenKlei commented 1 year ago

I would be fine with shipping the full pyMOR and VKOGA versions here to make the repo self-contained. Otherwise, I am a bit afraid that things might break at some point or become unnecessarily complicated.

renefritze commented 1 year ago

If pymor needs a branch/changes leave the setup as is. Submodules will just break in the future. If not, pin in requirements.

Semi-connected: put ./pymor in the requirements files to auto install it.

ftschindler commented 1 year ago

If pymor needs a branch/changes leave the setup as is. Submodules will just break in the future. If not, pin in requirements.

Semi-connected: put ./pymor in the requirements files to auto install it.

both good points, thx!