Open ecsedigergo opened 6 years ago
A general question in the end: did you test the changes together with the modules (components) which use the GpioManager
? Do these components work correctly after introducing the separate classes for CommandWriter
and CommandReader
in GpioManager
?
General answer: First of all I did not have yet opportunity and the knowledge to test it, but its true, its necessary before the merge.
If I may interrupt, I think version upgrades are not that big a deal
@zsoltmazlo There are two issues which might arise:
I wanted to use JUnit 5 and for that I had to upgrade the versions.
@ecsedigergo Argument is accepted. If it does not cause any compilation (/ runtime) problems, then the version upgrade is good to go.
If I may interrupt, I think version upgrades are not that big a deal