Closed hajduakos closed 3 years ago
sonarcloud[bot]
commented
3 years ago Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
hajduakos
commented
3 years ago Thanks @radl97 for checking the PR and your remarks. I fixed some of them, but I also have a question: what do you mean by "Can you check whether llvm-link-9 exists in the Ubuntu 18.04 too, maybe?" If I'm correct, if llvm-link does not exist, we'll try to run llvm-link-9. If that does not exist either, the eval command will give us an error, which is fine in this case.
sonarcloud[bot]
commented
3 years ago Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
This PR adds support for build and test with GH actions. Note that it uses Ubuntu 20.04 (as opposed to Travis, using 18.04). I also bumped the patch version number because one of the test scripts changed a bit due to aliases.
Nevertheless, I'd still keep Travis as well because it works and it does not hurt to have some redundancy. However, as soon as it needs significant efforts to maintain, we can just switch it off and only keep GH Actions.
Fixes #70