Closed dseight closed 4 years ago
LGTM
@dseight thank you for your contribution.
The only change that i have made on your code before merging the branch was to remove all c++11 specific code as the project is still C++98 compatible.
Well, in fact, I have found C++11 code already in the master branch from an older PR...and no one complained so i guess there is no point of keeping the C++98 support.
Thank you any way!
clazy
andclang-tidy
were used to check code. Some things are not fixed yet: the require thorough investigation.