search

ftylitak / qzxing

Qt/QML wrapper library for the ZXing library. 1D/2D barcode image processing library
Apache License 2.0
621 stars 340 forks source link

Revert cmake dep to be 3.2 #168

Closed dobey closed 4 years ago

dobey commented 4 years ago

The new style Qt5 find_package usage does not require newer CMake, nor do any of the other CMake commands for qzxing, so go back to only depending on CMake 3.2, to allow building on Ubuntu 16.04.

Fixes #167

Milerius commented 4 years ago

why this is merged @ftylitak ? This is a terrible Pull request which broke every of your users.

The path on windows using WIN32_DIR is likely not working because there is an extra zxing, when you have the sources already in the same Directory of CMakeLists.txt you don't have to use fancy variables

also next time @dobey don't be a sellfish user, and try to test your stuff EVERYWHERE before sending a pr. and doing modification on extra platform that you are not using.

dobey commented 4 years ago

also next time @dobey don't be a sellfish user, and try to test your stuff EVERYWHERE before sending a pr. and doing modification on extra platform that you are not using.

No need to be rude. I don't use windows. If you have a problem with the merge, then open an issue and tag it in here, and discuss it there. Complain about there not being CI which builds on Windows in all configurations. But don't presume yourself superior to others and come on here calling me selfish and demanding I solve your problems for you.

ftylitak commented 4 years ago

@Milerius, @dobey is right. The responsibility on anything that happens here is mine, not on the people that are giving their time to contribute. The fact that I had not tested it on Windows was my mistake and you should have opened an issue to report your opinion there stating also the urgency of your issue. Targeting on individuals in such a way is not acceptable and I hope it will never happen again.

Regardless, I will soon look at your contributions and proceed with the actions needed.

Milerius commented 4 years ago

@dobey @ftylitak we all have stress days :). Sorry for the rude words.

ftylitak commented 4 years ago

@Milerius indeed we all do.

Thank you for pointing out the issue in cmake.