search

fuadmoin / Recipe-app

This is an app that keeps track of all your recipes, ingredients, and inventory. It will allow you to save ingredients, keep track of what you have, create recipes, and generate a shopping list based on what you have and what you are missing from a recipe.
0 stars 0 forks source link

Ruby on Rails capstone kanban #12

Open SamTush opened 1 year ago

SamTush commented 1 year ago

Link to the Kanban board:

🔗 Recipe app Kanban board

- Our team has two members

  1. team member 1 - FuadMoin
  2. team member 2 - SamTush

Thank you for reviewing our Kanban board 😎

rloterh commented 1 year ago

Hi Team,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

Please provide the actual link to the Kanban board you created in your issue description.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

gemmen29 commented 1 year ago

Hi Team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights 💯

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

omarsalem7 commented 1 year ago

Hi @fuadmoin, @SamTush 😊,

STATUS: APPROVED! 🥇 💯

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: 🚀 Congratulations! 🎉

Highlights

✅ Project has met all the technical aspects you needed for this project. Keep rocking!

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.