fuatakgun / eufy_security

Home Assistant integration to manage Eufy Security devices as cameras, home base stations, doorbells, motion and contact sensors.
938 stars 79 forks source link

Map "Night" to native Home Assistant alarm state instead of Custom 2 #1150

Closed Ged-fi closed 6 months ago

Ged-fi commented 6 months ago

In #145 alarm_night was mapped to Custom 2 in Eufy.

However, Eufy and Home Assistant both "natively" support Night mode so the current mapping is unintuitive and requires creating a Custom alarm mode when Night would work better.

Home Assistant, especially using Mushroom cards will not display "Night" correctly with the current Custom mapping. Neither will Eufy display "Night".

Please reconsider mapping "alarm_night" natively to Night in Eufy.

If the Custom 2 mapping is required for Home Kit for some weird reason, consider adding an option "map night to Custom 2" in the configuration instead.

fuatakgun commented 6 months ago

Thanks for the idea and I agree that it looks unintuitive at first but we ended up in this state after finding out that Night is not a fixed mode across all models. Sharing a picture below from my home base 2.

Please check your home base's night mode if it is deletable, if yes, it is just another custom config so it means not everyone has it on their system Screenshot_2024-05-23-08-02-49-340_com.oceanwing.battery.cam.jpg

Ged-fi commented 6 months ago

Ah, I can confirm that "Night" is actually deletable on my model, so it does qualify as a custom config! As such, I agree with the current slightly un-intuitive implementation.

Sorry for the extra work in looking at this feature request. I suggest it can be closed.

Emptyless commented 1 month ago

Not sure if related but I'm trying to get "Night" mode to work in Homekit but the Home app remains stuck on "Arming...". I have two custom modes in the Eufy app (custom_1 => Morning, custom_2 => Night) and named them correspondingly as overrides in the Eufy Home Assistant integration. In the Home app, all modes but Night mode work. When selecting Night mode in the Home app, the Home Assistant state and the Eufy app get updated but the Home app remains, stuck - any thoughts on what could cause that?

edit: nevermind, I figured out that I should use the const declarations from the homeassistant/core (Override name for custom Guard mode 2: armed_night): image but leaving the comment open for others to find