search

fubuloubu / pytest-ethereum-old

py.test plugin for testing Ethereum smart contracts
MIT License
20 stars 1 forks source link

Remove hacky deployment kwargs mechanism in contract factory #7

Open fubuloubu opened 6 years ago

fubuloubu commented 6 years ago

I have this kwarg rewrite hack here, but it's not great: https://github.com/fubuloubu/pytest-ethereum/blob/da7f9f19c10b6bb6bd50a3fc75836672efeccf3f/pytest_ethereum/contract.py#L96-L99

The contract factory does not inherent this easier API from ConciseContract/ImplicitContract, but I was trying to leverage them the same way so you didn't have to context switch the kwargs with deployment factories.

Solution may require an update to web3.py. I mentioned this to @carver in gitter as an inconsistency in the API, not sure what would come of it.

carver commented 6 years ago

My attention will mostly be on trinity for a while.