fuda-cafe / hanafuda-art

Discover new hanafuda designs and play Koi-Koi using your favorite deck!
https://newhanafuda.art
0 stars 1 forks source link

refactor: update start screen #17

Closed AhamSammich closed 6 months ago

AhamSammich commented 6 months ago

fix: guest-login-button id

chore: update repo link

feat: add artist link to start page


Generated summary (powered by Graphite) > ## TL;DR > This pull request includes changes to the `StartScreenFooter.vue` and `login.vue` files. The changes include adding a link to the artist's portfolio, updating the GitHub repository link, and fixing a typo in the `login.vue` file. > > ## What changed > In `StartScreenFooter.vue`, a link to the artist's portfolio was added. The GitHub repository link was updated to point to the correct repository. The footer was also updated to include the name of the artist or contributor and the year of development. > > In `login.vue`, a typo in the id of the guest login button was fixed. > > ## How to test > To test these changes, follow these steps: > > 1. Pull the changes from this branch into your local environment. > 2. Navigate to the start screen and check the footer. You should see a link to the artist's portfolio, the updated GitHub repository link, and the updated footer text. > 3. Click on the artist's portfolio link. It should open the artist's portfolio in a new tab. > 4. Click on the GitHub repository link. It should open the correct repository in a new tab. > 5. Navigate to the login page and inspect the guest login button. The id should be `guest-login-button`. > > ## Why make this change > These changes were made to provide proper credit to the artist or contributor, to ensure that the GitHub repository link points to the correct repository, and to fix a typo in the `login.vue` file. These changes improve the user experience and the accuracy of the information provided on the site.
AhamSammich commented 6 months ago

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

github-actions[bot] commented 6 months ago

Visit the preview URL for this PR (updated for commit f439e3f):

https://new-hanafuda--pr17-refactor-start-scree-h70mqu6h.web.app

(expires Sat, 30 Dec 2023 23:14:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ad22d11d81bba23ffe16ef6682462fd93227f378

AhamSammich commented 6 months ago

Merge activity