fuddl / wd

a browser extension for wikidata
https://wikidata.org/wiki/Wikidata:Tools/Wikidata_for_Firefox
GNU General Public License v3.0
36 stars 6 forks source link

Weird bugs? #107

Closed derenrich closed 1 year ago

derenrich commented 1 year ago

So in the last few weeks the extension has started acting very odd. Really it hasn't worked properly for a while.

Accidental edits?

For example:

wd bug

But other things are also acting up.

Adding social media links

Another example:

vt bug

These may be disconnected issues but they only really started happening recently. And just generally things are slower/less reliable now. Or maybe it's in my head.

derenrich commented 1 year ago

I think maybe the first issue is caused by the sidepanel getting stuck on a previous page? Like it's not updating when I change pages reliably even after multiple refreshes.

Also, I'm on FF 107.0 Windows and running 0.286 of this extension.

fuddl commented 1 year ago

these are at least two separate issues. I will split them if you don't mind?

fuddl commented 1 year ago

Meta-Problem

So in the last few weeks the extension has started acting very odd. Really it hasn't worked properly for a while.

I'm not saying there isn't anything to improve. But I need a more specific task or a reproducable scenario. The extension is sometimes lagging behind but I don't know, how to tackle problems like this. I don't think i changed something groundbreaking recently but it might be that there are simply too many regex patterns that have to be queried and processed for every navigation event.

I think this could be improved by scoping them all to a specific domain. So instead of downloading all regex patterns I'd only download those which apply to a specific domain:

A wikidata statement with a domain qualifier

This would require a new property.

Accidental edits

I agree that this edit was probably made accidentally but there is nothing I can do to prevent that. With the current version it is nessesary to select a property in a dropdown first which should make acciental edits less likely.

Wrong entities

I cannot reproduce this. if anything Q113563433 should be shown on https://twitter.com/home. Which version do you use?

Social links

  • Links appear to add some social media
  • Clicking on the links does nothing

Are you sure nothing happends? In my case it adds a statement in the sidebar:

Screenshot 2022-11-30 at 16 57 15

fuddl commented 1 year ago

If you wan't to continue the discussion please do it in a separate issue. Issue compilations like this are painful to handle 😰