search

fuddl / wd

a browser extension for wikidata
https://wikidata.org/wiki/Wikidata:Tools/Wikidata_for_Firefox
GNU General Public License v3.0
36 stars 6 forks source link

Default instance of for books should be "written work" #130

Closed davidscotson closed 1 year ago

davidscotson commented 1 year ago

At the moment an instance of "book" is suggested, then changed to "edition" if an isbn is detected.

A default of "written work" would follow the wikidata book project defaults better.

(The presence of a page number count could also switch from "written work" to "edition" but that's probably a rare corner case and not worth worrying about)

fuddl commented 1 year ago

Thanks for your feedback. unfortunatly, the issue lies deeper.

Where exactly (link) did you find it?

I expect that this website will describe the entity as itemtype="https://schema.org/Book", which according to wikidata is "book".

Other websites might have a slightly different data model than wikidata. in this case you should uncheck the proposed property

davidscotson commented 1 year ago

I thought I'd tracked this in the code to here, (though I admit I hadn't actually tested changing it):

https://github.com/fuddl/wd/blob/aeb049f571ae72af31f719e96b8bd9c17a3a08fa/src/content/content__collect-meta.js#L18C18-L18C21

Where it sets the Q571 based on the opengraph tag.

An example that is currently unlinked to wikidata is here:

https://openlibrary.org/works/OL221334W/Blue_Highways?edition=ia%3Abluehighways00will

I'll give changing that line a go and see if it has any effect.

fuddl commented 1 year ago

i think this is fixed