search

fuddl / wd

a browser extension for wikidata
https://wikidata.org/wiki/Wikidata:Tools/Wikidata_for_Firefox
GNU General Public License v3.0
36 stars 6 forks source link

Help fix ID extraction from thecoversation.com #134

Closed RayBB closed 9 months ago

RayBB commented 9 months ago

Right now urls like https://theconversation.com/profiles/matan-shelomi-1245461 don't get picked up by wikidata for web.

But they should match this property: https://www.wikidata.org/wiki/Property:P8207

Any idea why this doesn't work? I don't recall if it ever worked but I've been using the site more so would like to start connecting it.

Thanks!

btcprox commented 9 months ago

I just tweaked the URL match pattern value on that property (which the extension relies on): it originally didn't account for the optional name segment in the URL (in your example, the matan-shelomi- bit). The correction should eventually allow the extension to detect and parse the URL correctly.

If you know your way around RegEx, you could potentially fix other ID properties in a similar manner by adjusting their URL match patterns.

fuddl commented 9 months ago

@RayBB @btcprox this issue as been solved already. Has it?

RayBB commented 9 months ago

It's working! Thanks for the help :)

fuddl commented 9 months ago

@RayBB there is an ongoing thread on my talk pag that is (I think) also monitored by other people. I might react quicker there. I'd recommend you to ask there next time 😉

For technical issues other that non-resolving urls, please post here.

RayBB commented 9 months ago

@fuddl should we maybe mention this in the readme? Like "If you are having problems with the ID extraction or url match patterns you should report it on this talk page as it is monitored by others as well. But for bugs in the extension itself they can be reported here."