search

fuddl / wd

a browser extension for wikidata
https://wikidata.org/wiki/Wikidata:Tools/Wikidata_for_Firefox
GNU General Public License v3.0
36 stars 6 forks source link

Add: make link resolution async, to speed up the process and make it more robust to any given resolution failing #53

Closed Stvad closed 2 years ago

fuddl commented 2 years ago

sure lets try

fuddl commented 2 years ago

i noticed that this crashes the resolution process when there are too many links on the page. Maybe the wikidata api refused to answer too many requests at once.

I propose to go back to synchronous resolution and make the process smarter, so that only links currently in the viewport get resolved.

Stvad commented 2 years ago

Hmm, can you provide an example page and what errors do you see?

Maybe the wikidata api refused to answer too many requests at once.

do we get an actual error from wikidata?

I don't think "links in the viewport" is actually what we want here though - like I want to collect any information that is potentially relevant from the page.

Also, maybe create a separate issue for the follow-up?

fuddl commented 2 years ago

jap. sorry. this was a false alarm