fuddl / wd

a browser extension for wikidata
https://wikidata.org/wiki/Wikidata:Tools/Wikidata_for_Firefox
GNU General Public License v3.0
36 stars 6 forks source link

No longer works with P2456 #88

Closed louisroyer closed 2 years ago

louisroyer commented 2 years ago

Hi, on pages of dblp.org about authors who do not have an existing item on Wikidata, P31>Q1172284 is proposed instead of P31>Q5 (no longer proposed).

Could the addon still propose P31>Q5 (from constraints on P2456)?

The problem seems to come from HTML metadata which contains:

{
  "@context": "http://schema.org",
  "@type": "Dataset",
  "url": "https://dblp.org/xml/release",
  "sameAs": [
    "https://dblp.uni-trier.de/xml/release",
    "https://dblp.dagstuhl.de/xml/release"
  ],
  "name": "dblp XML data dump",
  "description": "The raw dblp metadata in XML files as stable, persistent releases.",
  "keywords": "dblp, XML, computer science, scholarly publications, metadata",
  "temporalCoverage": "1936/..",
  "thumbnailUrl": "https://dblp.org/img/dblp.icon.192x192.png",
  "creator": {
    "@context": "http://schema.org",
    "@type": "Organization",
    "name": "Schloss Dagstuhl - Leibniz Center for Informatics",
    "url": "https://www.dagstuhl.de",
    "logo": "https://www.dagstuhl.de/fileadmin/assets/images/lzi_logo.gif",
    "contactPoint": {
      "@context": "http://schema.org",
      "@type": "ContactPoint",
      "contactType": "customer support",
      "url": "https://dblp.org/db/about/team",
      "email": "dblp@dagstuhl.de"
    },
    "sameAs": [
      "https://www.wikidata.org/entity/Q879857",
      "https://en.wikipedia.org/wiki/Dagstuhl"
    ]
  },
  "dateCreated": "1993",
  "datePublished": "1993",
  "dateModified": "2022-07-02",
  "locationCreated": "Trier, Germany",
  "funder": [
    {
      "@context": "http://schema.org",
      "@type": "Organization",
      "name": "Leibniz Association",
      "url": "https://www.leibniz-gemeinschaft.de/",
      "logo": "https://www.leibniz-gemeinschaft.de/fileadmin/portal/logo-black.svg",
      "sameAs": [
        "https://www.wikidata.org/entity/Q680090",
        "https://en.wikipedia.org/wiki/Leibniz_Association"
      ]
    },
    {
      "@context": "http://schema.org",
      "@type": "Organization",
      "name": "Federal Ministry of Education and Research of Germany",
      "url": "https://www.bmbf.de/",
      "logo": "https://www.bmbf.de/site/img/logo.png",
      "sameAs": [
        "https://www.wikidata.org/entity/Q492234",
        "https://en.wikipedia.org/wiki/Federal_Ministry_of_Education_and_Research_(Germany)"
      ]
    },
    {
      "@context": "http://schema.org",
      "@type": "Organization",
      "name": "Saarland State Chancellery",
      "url": "https://www.saarland.de/staatskanzlei.htm",
      "logo": "https://www.saarland.de/bilder/res_stk/stk.png",
      "sameAs": [
        "https://www.wikidata.org/entity/Q15848758",
        "https://de.wikipedia.org/wiki/Saarl%C3%A4ndische_Staatskanzlei"
      ]
    },
    {
      "@context": "http://schema.org",
      "@type": "Organization",
      "name": "Ministry of Science, Education and Culture of the State of Rhineland-Palatinate",
      "url": "https://mwwk.rlp.de/de/startseite//",
      "logo": "https://mwwk.rlp.de/fileadmin/_logos/rlp-logos-MWWK.png",
      "sameAs": [
        "https://www.wikidata.org/entity/Q15835282",
        "https://de.wikipedia.org/wiki/Ministerium_f%C3%BCr_Wissenschaft,_Weiterbildung_und_Kultur"
      ]
    }
  ],
  "genre": "computer science",
  "inLanguage": "en-US",
  "license": "https://creativecommons.org/publicdomain/zero/1.0/",
  "isAccessibleForFree": "true",
  "distribution": [
    {
      "@type": "DataDownload",
      "encodingFormat": "application/gzip",
      "contentUrl": "https://dblp.org/xml/release/"
    }
  ]
}
fuddl commented 2 years ago

You mean, it seams to crash on pages like dblp.org/pid/269/4682:

wikidata for firefox crashed

I guess, thats what you mean.

louisroyer commented 2 years ago

Yes, but it works correctly on items with already a WD item: 2022-07-03T18:48:10,247497998+02:00 On pages where item does not exist yet, I expected to be able to create the WD item from the tool.

fuddl commented 2 years ago

please upgrade to version .233. If the error persists, reopen this issue. Thanks for reporting 👌

louisroyer commented 2 years ago

Thank you :)