Fix/minor fixes - Githubissues

modersohn commented 2 years ago

3 minor fixes in on PR:

GetTransactions query fix with block being part of the where (this came up when we were testing our own subgraph temporarily in PR #112, see my very last comment there)
fix null warning with new search dialog from PR #129
move transaction export dialog to new dialogs subdir created in PR #129 too

modersohn commented 2 years ago

@danielsolistensvik - I can't add you as a reviewer (yet, maybe once you participate here), but could you have a look and let me know what you think?

daniel-soli commented 2 years ago

Yeah, I'll take a look in a couple of hours :) I think it's something to do with rights, but its not a prob.

modersohn commented 2 years ago

OK, no rush - even if I might state the obvious: if you want to try the code, just add my clone as an additional origin and then checkout my fix branch.

modersohn commented 2 years ago

Thanks for looking at this.

The bug with the GetTransactions query actually doesn't manifest with the graph deployment we're currently using. Although the query is technically not correct, the server still correctly answers as intended. If you want, you can check out https://thegraph.com/hosted-service/subgraph/juanmardefago/loopring36?selected=playground. If you look at the transactions query, it has a parameter called "block" which is of type Block_height. But what we actually want to use here, is the field "block" from "Transaction_filter", i.e. part of the "where".

I'll merge now with dev and then will create a PR for fudgey to merge with master, so everybody can benefit from the progress.

fudgebucket27 / Lexplorer

Fix/minor fixes #132