search

fudgebucket27 / Lexplorer

Loopring explorer alternative
14 stars 10 forks source link

Show holding wallets in NFT details #179

Closed modersohn closed 2 years ago

modersohn commented 2 years ago

Should be doable by querying all non-empty nftslots for a given NFT id.

Probably needs extra pagination etc.

daniel-soli commented 2 years ago

I tried looking at this and it seems I have figured it out. At least I gave it a shot. At the moment I just added a table to the end of the NFT details page like so:
image Branch can be seen here

Take a look and see if this is what you had in mind :) If not, no worries :)

modersohn commented 2 years ago

From just looking at the screenshot, yeah - something like that! Nice!

Instead of separate account id and address, I think there's some link helper method that can show both in one link (like in transaction details etc).

And the question is: what should we sort by? Balance aka amount could be an option, not sure what else.

Anyway, looking good, but I won't have time to look at the actual code today, hopefully tomorrow.

daniel-soli commented 2 years ago

I'm off until tomorrow myself, but we can take a closer look when you get back :)

modersohn commented 2 years ago

OK, I had a quick look at the code - that's definitely good enough for a PR and then we can discuss things there. So, please make a PR!

daniel-soli commented 2 years ago

Will do Mr. :)

modersohn commented 2 years ago

I'll close this as it is done in general. For any further improvements (tabs? links for id as well?) we should open separate issues.