fudgebucket27 / Lexplorer

Loopring explorer alternative
14 stars 10 forks source link

Several fixes for misbehaving NFTGrid #198

Closed modersohn closed 2 years ago

modersohn commented 2 years ago

Follow-up for #195 after discovering several issue

modersohn commented 2 years ago

Well, silly me thought I'd learned so much about writing Blazor components after #195 but there's been numerous issue with that. Essentially a component should never change its own [Parameter] and you basically get OnParameterSetAsync call for each one, maybe even more and even if it didn't actually change. Which makes it very tricky to decide when to actually try to load the NFT data here and when to cancel previously running loads.

I'd appreciate if you could give this a proper look but almost more importantly a proper test drive (maybe even after the merge on dev deployment?). Switching pages with/without interrupting it, but also hiding the NFTGrid by switching to balances (because then it'll get released!), also checking out collections. There were so many issues, it's not very likely I caught them all.

modersohn commented 2 years ago

I'll merge this into dev for now, so testing can happen on the dev deployment