search

fudgebucket27 / Lexplorer

Loopring explorer alternative
14 stars 10 forks source link

Feature: Show nft holders #200

Closed daniel-soli closed 2 years ago

daniel-soli commented 2 years ago

Closes #179

Features:

modersohn commented 2 years ago

I'll have this running locally now and the ordering by balance is pretty nice I must say!

  1. What's your view on having transactions and holders on tabs? A bit like account balances and NFTs. One reason being that any change to the URL (i.e. navigating pages etc.) scrolls the page up for me.
  2. And what about account id being a link too? Or the combination where address and accountId in brackets (like the minter on the same page in the NFT details).

If you'd prefer to merge as is and keep these things open for now, that's fine by me too.

daniel-soli commented 2 years ago

That's nice :)

  1. I think we should have a review at a later point anyways where we decide on different layouts, especially this one. And yeah I also have that "problem". But I don't know if its an issue we have to redo now. Functionality for me trumps over view in this stage. But definitely have a makeover at a later point, IF you do not have a solution now ofc :)
  2. With the account and address I have a split view :| I like them both hehe. But this can also be an enhancement at a later point :) We'll let it grow a bit, and we will quickly find out what we would like to change I bet.

I'll merge it as is. And like I said, it's easy to do an enhancement at any time :) Please do some enhancement right away if you got some nice ideas :) 👍🏻

Edit: Seems like I cannot merge this so you would have to do it I guess

modersohn commented 2 years ago

As discussed here and on Discord, I'll squash merge and we keep further changes for a later time