search

fudgeu / playlist

Control Minecraft's in-game music - In-game music player
14 stars 1 forks source link

Add Russian localisation #3

Closed Felix14-v2 closed 2 years ago

Felix14-v2 commented 2 years ago

Hi! After the death of MineAmp, I stopped hoping that I would ever see a mod that would make up for this loss. Thank you for working on this, the opportunity to listen to music without switching out of the game is just incredible!

I translated the available UI elements into my native language, based on my previous translation experience and the interfaces of usual media players. Some of the messages have been localized to stylistically match the general style of existing programs, the other part had to be shortened so that the phrases fit into the space allocated for them. lang.zip

There are also several stylistic improvements: image (if these are bad decisions according to the author of the mod, I have nothing against removing them)

It would also be nice to see the mod's source code on GitHub. At least it would make it easier for other people to contribute and protect the project from possible oblivion, as happened with MineAmp at the time of 1.14...

fudgeu commented 2 years ago

Hi, thank you! I plan on adding support for Crowdin soon, so adding localizations should hopefully be easier in the future - but I'll definitely add your Russian localization for now and credit you

As for the UI suggestions, I'll definitely take them in mind! Right now, I'm mostly working on fixing the many bugs and other small things, but I'll be getting back to adding new features and improvements soon.

I'll upload the source code pretty soon, likely when the mod reaches a stable release - It's my first real Minecraft mod, and it was definitely a learning process so I want to be able to clean up and document some of the code better before I release it, lol.

Also, I noticed that the background blur mod you have seems to get rid of the darkening, making it a bit harder to see the text. Is this on purpose? If not, I can try to see what I can do to get that mod working well with mine to make sure text is readable.

Felix14-v2 commented 2 years ago

I noticed that the background blur mod you have seems to get rid of the darkening, making it a bit harder to see the text. Is this on purpose? If not, I can try to see what I can do to get that mod working well with mine to make sure text is readable.

There is an exclusions field in this mod: image but I don't know how to use it...

By the way, Playlist has a hardcoded width of some UI elements, which sometimes leads to the following: image

So, should this issue be closed?

fudgeu commented 2 years ago

There is an exclusions field in this mod, but I don't know how to use it...

I'm not too sure either, haha, but you can try to put in com.fudgeu.playlist.gui.PlaylistScreen to see if that does anything!

By the way, Playlist has a hardcoded width of some UI elements, which sometimes leads to the following:

Gotcha, I'll work on trying to make that dynamic. I already have other updates to the context menu to push anyway so lol

I'll close the issue for now, thank you!