Return value of delete_user($username) - Githubissues

fuel / auth

Fuel PHP Framework - Fuel v1.x Authentication package

http://fuelphp.com/docs/packages/auth/intro.html

76 stars 57 forks source link

Return value of delete_user($username) #85

Closed iwashi closed 10 years ago

iwashi commented 10 years ago

According to function comment as below, delete_user($username) should return boolean value.

https://github.com/fuel/auth/blob/61e3c14e9a5bd325e1f41f46b1e10e99504342b1/classes/auth/login/ormauth.php#L481

However, it seems that delete user($username) returns "Model this instance as a new object without primary key(s)" shown as below:

https://github.com/fuel/orm/blob/e8457ba9296078310cdea47002e5c7b7cb083da2/classes/model.php#L1456

I think that delete_user($username) should return boolean value as documented.

WanWizard commented 10 years ago

Duplicate of #86