Closed iwashi closed 10 years ago
It can even be condensed to
if ($user)
{
return (bool) $user->delete();
}
return false;
return (bool) $user->delete();
looks good. :+1:
You update the PR, or I close it and change it myself?
@WanWizard He updated this PR already. See "File changed"
@kenjis I think, @WanWizard wants to have the else
statement removed. Find this:
if ($user)
{
return (bool) $user->delete();
}
else
{
return false;
}
and replace it with this:
if ($user)
{
return (bool) $user->delete();
}
return false;
Exactly. The else is redundant there.
Okay, I'm going to update PR from now.
Thanks.
As I wrote issue #85, user_delete() should return true when it's successful.