search

fuel / core

Fuel PHP Framework - The core of the Fuel v1 framework
http://fuelphp.com
813 stars 345 forks source link

Duplicate slashes / for path while using Asset::css/img/js in Windows #1143

Closed axelitus closed 12 years ago

axelitus commented 12 years ago

Using FuelPHP v1.2.1:

I'm using Asset::css() and Asset::img() in a site. When running the site on linux everything works as expected but when running on Windows I get duplicate slashes in the path.

linux: http://local/assets/css/styles.css?1347035649

windows: http://local/assets//css//styles.css?1347035649

I've dig a little bit into it and it seems as the paths for the asset folder are being strangely built, when running $this->_asset_paths['css'] (on Assets this call is in line 397 in the foreach loop) I get the following assets path: assets/\css/\

At the end there's a call to return str_replace(DS, '/', $file); which replaces the back-slashes with forward-slashes thus returning: assets//css//

I think this issue is deeper inside Fuel, where the paths are "calculated".

I'll try to test this with the 1.3/develop branch, but I'm guessing I'll get the same result.

axelitus commented 12 years ago

Actually this seems to be fixed in the 1.3/develop branch (I just replaces the core folder from the 1.2.1 version to the latest 1.3/develop clone). Hopefully we can reach a stable 1.3 version soon :)

I'll close this now as this has been fixed