fuel / core

Fuel PHP Framework - The core of the Fuel v1 framework
http://fuelphp.com
813 stars 345 forks source link

Test failing #1352

Closed it-can closed 11 years ago

it-can commented 11 years ago

Time: 1 second, Memory: 29.50Mb

There were 4 failures:

1) Fuel\Core\Test_Pagination::test_uri_segment_first_page Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'123456' +'12345'

/fuel/core/tests/pagination.php:206

2) Fuel\Core\Test_Pagination::test_uri_segment_nextlink_inactive Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'678910' +'6789'

/fuel/core/tests/pagination.php:239

3) Fuel\Core\Test_Pagination::test_query_string_first_page Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'123456' +'12345'

/fuel/core/tests/pagination.php:439

4) Fuel\Core\Test_Pagination::test_query_string_nextlink_inactive Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'678910' +'6789'

/fuel/core/tests/pagination.php:468

FAILURES! Tests: 342, Assertions: 377, Failures: 4.

it-can commented 11 years ago

@WanWizard can you take a look at this?

WanWizard commented 11 years ago

Ah. People should stop writing tests to match results. This was a bug that was fixed, so clearly the tests were wrong... Fix is on the way.

it-can commented 11 years ago

Ok, well good to know ;-)