fuel / core

Fuel PHP Framework - The core of the Fuel v1 framework
http://fuelphp.com
802 stars 335 forks source link

[PHP 8.4] Fix: Curl `CURLOPT_BINARYTRANSFER` deprecated #2204

Closed Ayesh closed 5 months ago

Ayesh commented 5 months ago

The CURLOPT_BINARYTRANSFER PHP constant from the Curl extension was no-op since PHP 5.1, and is deprecated in PHP 8.4. This removes the constant usage to avoid the deprecation notice in PHP 8.4 and later.

Because this constant was no-op since PHP 5.1 (circa 2005), this change has no impact.

See:

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Ayesh commented 5 months ago

Thank you! Really appreciate the quick review and merging 🙏.