search

fuel / core

Fuel PHP Framework - The core of the Fuel v1 framework
http://fuelphp.com
811 stars 344 forks source link

feat: Allow monolog/monolog v2 and v3 #2205

Closed siketyan closed 8 months ago

siketyan commented 8 months ago

monolog is used in many PHP libraries but monolog v1 is no longer supported in most ones; we can not install fuel/core along with the libraries. This pull request adds support for monolog 2.x and 3.x. I could not find any required changes to fuel/core itself so we can upgrade safely. Users can select their favourite monolog version to use: pin to 1.x or upgrade to 2.x or 3.x.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

WanWizard commented 8 months ago

If the API has remained the same, not a problem. The choice for monolog version is mainly dependent on PHP version used.

I'll do some testing with v2 and v3 today, before I merge this.

WanWizard commented 8 months ago

For others finding this PR:

note that if you use custom processors or formatters, the API will have changed, so you need to update those when you update monolog.